Skip to content

Make GitHub Actions upload the test log as an artifact (related to #338) #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hartwork
Copy link
Contributor

In reaction to #338 (comment)

@henry2cox
Copy link
Collaborator

henry2cox commented Dec 18, 2024

Well - bummer.
That didn't help with #343 as much as I thought it might :-(
Will help with other issues though, I expect.

Peripherally related: when you run tests locally (in your sandbox - not on github) - do you see a similar failure in the py2lcov test?
If you do - could you attach the offending 'functions.xml' file somewhere, so we can study it?

@henry2cox henry2cox merged commit ae8e517 into linux-test-project:master Dec 18, 2024
2 checks passed
@hartwork
Copy link
Contributor Author

Peripherally related: when you run tests locally (in your sandbox - not on github) - do you see a similar failure in the py2lcov test?

@henry2cox I did not see any failures in my Docker-based attempts to reproduce the failures from #343. It was the exact opposite of what I had hoped for.

@hartwork hartwork deleted the make-ci-upload-test-log-as-an-artifact branch December 18, 2024 23:26
@henry2cox
Copy link
Collaborator

Hmm
Now there is a bummer.

Hacky - but I think we need to artifact the "tests" directory (maybe temporarily) - so we can see the shrapnel.

Like you, I can't seem to reproduce the issue.

@henry2cox
Copy link
Collaborator

The other thing I can do, to make that artifact a bit less painful - is to clean each rundir if the corresponding test passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants